aratno commented on code in PR #4428:
URL: https://github.com/apache/cassandra/pull/4428#discussion_r2539797254
##########
src/java/org/apache/cassandra/db/ReadExecutionController.java:
##########
@@ -243,4 +261,27 @@ private void addSample()
if (cfs != null)
cfs.metric.topLocalReadQueryTime.addSample(cql, timeMicros);
}
+
+ public void addActivationIds(ColumnFamilyStore.ViewFragment view)
+ {
+ Preconditions.checkState(metadata().replicationType().isTracked());
+ if (activationIds == null)
+ activationIds = new HashSet<>();
Review Comment:
Looked more closely, and the case I was thinking of isn't across threads.
Even when we're in `SinglePartitionReadCommand.Group.executeLocally`, we have a
shared instance of ReadExecutionController across executions, but they're
executing in serial on a single thread, so there's no concurrent access.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
