belliottsmith commented on code in PR #4491:
URL: https://github.com/apache/cassandra/pull/4491#discussion_r2553146336
##########
src/java/org/apache/cassandra/repair/RepairCoordinator.java:
##########
@@ -447,11 +452,12 @@ else if (isMeta && !isCMS)
if (shouldExcludeDeadParticipants)
{
- Set<InetAddressAndPort> actualNeighbors =
Sets.newHashSet(Iterables.filter(allNeighbors, ctx.failureDetector()::isAlive));
- shouldExcludeDeadParticipants =
!allNeighbors.equals(actualNeighbors);
- allNeighbors = actualNeighbors;
+ Set<InetAddressAndPort> actualNeighbors =
Sets.newHashSet(Iterables.filter(includeNeighbors,
ctx.failureDetector()::isAlive));
+ shouldExcludeDeadParticipants =
!includeNeighbors.equals(actualNeighbors);
+ if (shouldExcludeDeadParticipants) includeNeighbors =
actualNeighbors;
+ else logger.info("{} all replicas {} considered up and healthy;
clearing force flag for this job", state.id, includeNeighbors);
}
- return new NeighborsAndRanges(shouldExcludeDeadParticipants,
allNeighbors, commonRanges);
+ return new NeighborsAndRanges(shouldExcludeDeadParticipants,
includeNeighbors.containsAll(allNeighbors), includeNeighbors, commonRanges);
Review Comment:
I think we need it still, if only to handle the possibility we filter dead
nodes later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
