belliottsmith commented on code in PR #4491:
URL: https://github.com/apache/cassandra/pull/4491#discussion_r2553147287
##########
src/java/org/apache/cassandra/repair/RepairJob.java:
##########
@@ -179,20 +183,23 @@ protected void runRepair()
if (doAccordRepair)
{
accordRepair = paxosRepair.flatMap(unused -> {
- boolean requireAllEndpoints;
- // If the session excluded dead nodes it's not eligible for
migration and is not supposed to occur at ALL anyways
- if (session.excludedDeadNodes)
- requireAllEndpoints = false;
- else
+ SyncRemote sync;
+ if (session.excludedDeadNodes || !session.allReplicas)
+ {
+ // not guaranteed to even have a quorum for a force
repair??
Review Comment:
Perhaps we can separately calculate if we have a quorum; I'll make that
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
