smiklosovic commented on code in PR #4514:
URL: https://github.com/apache/cassandra/pull/4514#discussion_r2590512593
##########
test/unit/org/apache/cassandra/schema/SystemDistributedKeyspaceCompressionDictionaryTest.java:
##########
@@ -156,8 +156,8 @@ public void testRetrieveSpecificDictionary() throws
Exception
.as("Should retrieve correct dictionary by ID")
.isEqualTo(testDictionary2.dictId());
- dict1.close();
- dict2.close();
+ dict1.selfRef().close();
+ dict2.selfRef().close();
Review Comment:
looking at this ... could not CompressionDictionary implement Auto/Closeable
and implementations would implement it like this
````
public void close() { selfRef().close(); }
````
maybe it could be default method on CompressionDictionary already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
