yifan-c commented on code in PR #4514:
URL: https://github.com/apache/cassandra/pull/4514#discussion_r2590559907
##########
test/unit/org/apache/cassandra/db/compression/ZstdCompressionDictionaryTest.java:
##########
@@ -355,8 +387,8 @@ public void testSerializeDeserializeWithManager() throws
Exception
.isNotNull()
.isEqualTo(dict2);
- dict1.close();
- dict2.close();
+ dict1.selfRef().release();
Review Comment:
ref#close and ref#release are quite similar and have some subtle
differences. For the test code, they can be used interchangeably.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]