yifan-c commented on code in PR #4514: URL: https://github.com/apache/cassandra/pull/4514#discussion_r2593835617
########## src/java/org/apache/cassandra/io/compress/ZstdDictionaryCompressor.java: ########## Review Comment: You are reading it correctly. Just to add a bit more context, the `instancesPerLevel` map only holds the `ZstdDictionaryCompressor` instances w/o dictionary, which are basically the same as `ZstdCompressor` or minimum java objects. They are cheap. The map in `ZstdDictionaryCompressor` is the same pool mechanism as used in `ZstdCompressor` and `LZ4Compressor`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
