jyothsnakonisa commented on PR #294: URL: https://github.com/apache/cassandra-sidecar/pull/294#issuecomment-3639372160
Thanks @bbotella for addressing my comments. There is this comment https://github.com/apache/cassandra-sidecar/pull/294#discussion_r2604697127 which is not resolved. We need to look into that codepath as it is critical for leader election and mutation publishing. Also, can you please check if there is a way to add an end to end test that checks if the mutations are published(in-memory) might not need to have kafka for the test. Other than those two everything else looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
