jyothsnakonisa commented on code in PR #294:
URL: https://github.com/apache/cassandra-sidecar/pull/294#discussion_r2608553761
##########
server/src/test/java/org/apache/cassandra/sidecar/cdc/CdcConfigImplTest.java:
##########
@@ -150,103 +137,11 @@ void testConfigsWhenConfigsAreNotEmpty()
assertThat(cdcConfig.persistDelay()).isEqualTo(new
MillisecondBoundConfiguration(5, TimeUnit.SECONDS));
}
- @Test
- void testConfigChanged() throws Exception
Review Comment:
But I think the test is sill valid right? may be we should have the test to
check if the vertx signal is made when config is changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
