maedhroz commented on code in PR #4426:
URL: https://github.com/apache/cassandra/pull/4426#discussion_r2611344742
##########
src/java/org/apache/cassandra/service/StorageServiceMBean.java:
##########
@@ -452,7 +452,7 @@ default int scrub(boolean disableSnapshot, boolean
skipCorrupted, boolean checkD
* The entire sstable will be read to ensure each cell validates if
extendedVerify is true
*/
public int verify(boolean extendedVerify, String keyspaceName, String...
tableNames) throws IOException, ExecutionException, InterruptedException;
- public int verify(boolean extendedVerify, boolean checkVersion, boolean
diskFailurePolicy, boolean mutateRepairStatus, boolean checkOwnsTokens, boolean
quick, String keyspaceName, String... tableNames) throws IOException,
ExecutionException, InterruptedException;
+ public int verify(boolean extendedVerify, boolean checkVersion, boolean
diskFailurePolicy, boolean mutateRepairStatus, boolean checkOwnsTokens, boolean
quick, boolean onlySai, boolean includeSai, String keyspaceName, String...
tableNames) throws IOException, ExecutionException, InterruptedException;
Review Comment:
That's fair...might be better to just keep the existing signature and add a
new one. Method with the existing signature in `StorageService` can just
default them to `false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
