dcapwell commented on code in PR #4426:
URL: https://github.com/apache/cassandra/pull/4426#discussion_r2611742801
##########
src/java/org/apache/cassandra/tools/nodetool/Verify.java:
##########
@@ -89,6 +99,9 @@ public void execute(NodeProbe probe)
System.exit(1);
}
+ if (onlySai && includeSai)
+ throw new IllegalArgumentException("Cannot specify both --sai-only
and --include-sai");
Review Comment:
im ok if we want to keep this, but similar APIs have added flags to change
the defaults; maybe we *should* validate SAI by default? If we make that a
flag than `onlySai` becomes unsafe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
