dkropachev commented on code in PR #801:
URL: https://github.com/apache/cassandra-ccm/pull/801#discussion_r2617617955
##########
setup.cfg:
##########
@@ -11,10 +11,8 @@ classifier=
'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
- 'Programming Language :: Python :: 3.3',
- 'Programming Language :: Python :: 3.4',
- 'Programming Language :: Python :: 3.5',
- 'Programming Language :: Python :: 3.6'
+ 'Programming Language :: Python :: 3.8',
Review Comment:
3.8 is EOL in October this year, probably it would be better to start from
3.9
##########
.github/workflows/main.yml:
##########
@@ -14,34 +14,38 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-name: CI
+name: CI - Python 3.x
on:
push:
pull_request:
workflow_dispatch:
jobs:
- build:
+ lint_test_smoke:
runs-on: ubuntu-24.04
+ strategy:
+ matrix:
+ python-version: ['3.8', '3.11'] # TODO add '3.12' '3.13' '3.14'
+ fail-fast: false
steps:
- uses: actions/checkout@v4
- - name: Create virtual environment
- run: python -m venv venv
-
- - name: Activate virtual environment
- run: source venv/bin/activate
+ - name: Set up Python ${{ matrix.python-version }}
+ uses: actions/setup-python@v5
+ with:
+ python-version: ${{ matrix.python-version }}
- - name: Install dependencies
- run: pip install -r requirements.txt && pip install -r
tests/requirements.txt
+ - name: Set up Python environment
+ run: |
+ pip install --upgrade pip
+ pip install -r requirements.txt && pip install -r
tests/requirements.txt
- name: Run linter
- run: pylint --output-format msvs --reports y ccmlib || true
-
- - name: Run linter for tests
- run: pylint --output-format msvs --reports y tests || true
+ run: |
+ pylint --output-format msvs --reports y ccmlib || true
+ pylint --output-format msvs --reports y tests || true
Review Comment:
You want to ignore when pylint fails ?
##########
setup.cfg:
##########
@@ -11,10 +11,8 @@ classifier=
'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
Review Comment:
Are you sure you want to support 2.x ?
It has reached EOL in 2020
##########
.github/workflows/main.yml:
##########
@@ -51,27 +55,39 @@ jobs:
run: |
sudo ./setup.py install
set -x
-
+ LATEST_4_0=$(curl -s https://downloads.apache.org/cassandra/ | grep
-oE '4\.0\.[0-9]+' | sort -V | tail -1)
+ LATEST_4_1=$(curl -s https://downloads.apache.org/cassandra/ | grep
-oE '4\.1\.[0-9]+' | sort -V | tail -1)
+ LATEST_5_0=$(curl -s https://downloads.apache.org/cassandra/ | grep
-oE '5\.0\.[0-9]+' | sort -V | tail -1)
ccm_test() {
- for i in {1..9}; do
+ for i in {1..9}; do
echo "Checking nc -z 127.0.0.1 7000"
while nc -z 127.0.0.1 7000 ; do echo . ; ./ccm stop || true ;
sleep 1 ; done
- ./ccm start && ./ccm remove && return 0 || echo retrying
+ ./ccm start -v && ./ccm remove && return 0 || echo retrying
sleep 20
done
echo "ccm start failed after 9 attempts"
exit 1
}
export -f ccm_test
./ccm create -h
- ./ccm create test -v 5.0.3 -n1 --vnodes --quiet
+ ./ccm create test -v ${LATEST_4_0} -n1 --vnodes --quiet
+ ccm_test
+ ./ccm create test -v ${LATEST_4_1} -n1 --vnodes --quiet
+ ccm_test
+ ./ccm create test -v ${LATEST_5_0} -n1 --vnodes --quiet
+ ccm_test
+ ./ccm create test --version='git:cassandra-4.0' -n1 --vnodes --quiet
+ ccm_test
+ ./ccm create test --version='git:cassandra-4.1' -n1 --vnodes --quiet
+ ccm_test
+ ./ccm create test --version='git:cassandra-5.0' -n1 --vnodes --quiet
ccm_test
- ./ccm create test --version='git:cassandra-5.0.3' -n1 --vnodes
--quiet
+ ./ccm create test --version='git:trunk' -n1 --vnodes --quiet
Review Comment:
does not seems correct, trunk is not stable, it may fail because trunk is
broken
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
