michaelsembwever commented on code in PR #801:
URL: https://github.com/apache/cassandra-ccm/pull/801#discussion_r2618406326
##########
.github/workflows/main.yml:
##########
@@ -51,27 +55,39 @@ jobs:
run: |
sudo ./setup.py install
set -x
-
+ LATEST_4_0=$(curl -s https://downloads.apache.org/cassandra/ | grep
-oE '4\.0\.[0-9]+' | sort -V | tail -1)
+ LATEST_4_1=$(curl -s https://downloads.apache.org/cassandra/ | grep
-oE '4\.1\.[0-9]+' | sort -V | tail -1)
+ LATEST_5_0=$(curl -s https://downloads.apache.org/cassandra/ | grep
-oE '5\.0\.[0-9]+' | sort -V | tail -1)
ccm_test() {
- for i in {1..9}; do
+ for i in {1..9}; do
echo "Checking nc -z 127.0.0.1 7000"
while nc -z 127.0.0.1 7000 ; do echo . ; ./ccm stop || true ;
sleep 1 ; done
- ./ccm start && ./ccm remove && return 0 || echo retrying
+ ./ccm start -v && ./ccm remove && return 0 || echo retrying
sleep 20
done
echo "ccm start failed after 9 attempts"
exit 1
}
export -f ccm_test
./ccm create -h
- ./ccm create test -v 5.0.3 -n1 --vnodes --quiet
+ ./ccm create test -v ${LATEST_4_0} -n1 --vnodes --quiet
+ ccm_test
+ ./ccm create test -v ${LATEST_4_1} -n1 --vnodes --quiet
+ ccm_test
+ ./ccm create test -v ${LATEST_5_0} -n1 --vnodes --quiet
+ ccm_test
+ ./ccm create test --version='git:cassandra-4.0' -n1 --vnodes --quiet
+ ccm_test
+ ./ccm create test --version='git:cassandra-4.1' -n1 --vnodes --quiet
+ ccm_test
+ ./ccm create test --version='git:cassandra-5.0' -n1 --vnodes --quiet
ccm_test
- ./ccm create test --version='git:cassandra-5.0.3' -n1 --vnodes
--quiet
+ ./ccm create test --version='git:trunk' -n1 --vnodes --quiet
Review Comment:
trunk should never break it (it has its own tests), and if the breakage is
on our side we want to catch that early.
(yeah it introduces some noise for PR authors for a breakage that came else
where, and the author has to let the right people know who can step in and
help, but catching it early is still beneficial imho)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
