smiklosovic commented on code in PR #4523:
URL: https://github.com/apache/cassandra/pull/4523#discussion_r2620315970
##########
src/java/org/apache/cassandra/tools/NodeProbe.java:
##########
@@ -2692,15 +2692,25 @@ public void setMixedMajorVersionRepairEnabled(boolean
enabled)
* Triggers compression dictionary training for the specified table.
* Samples chunks from existing SSTables and trains a dictionary.
*
- * @param keyspace the keyspace name
- * @param table the table name
- * @param force force the dictionary training even if there are not enough
samples
- * @throws IOException if there's an error accessing the MBean
- * @throws IllegalArgumentException if table doesn't support dictionary
compression
+ * @param keyspace the keyspace name
+ * @param table the table name
+ * @param force force the dictionary training even if
there are not enough samples
+ * @param trainingMaxDictionarySize maximum dictionary size to create, if
not set, CQL parameter value is used
+ * @param trainingMaxTotalSampleSize maximum total sample size, if not
set, CQL parameter value is used
+ * @throws IOException if there's an error accessing the
MBean
+ * @throws IllegalArgumentException if table doesn't support dictionary
compression
*/
- public void trainCompressionDictionary(String keyspace, String table,
boolean force) throws IOException
- {
- doWithCompressionDictionaryManagerMBean(proxy -> { proxy.train(force);
return null; }, keyspace, table);
+ public void trainCompressionDictionary(String keyspace, String table,
Review Comment:
I was becoming way too long on the screen so I reformatted this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
