smiklosovic commented on code in PR #4513:
URL: https://github.com/apache/cassandra/pull/4513#discussion_r2623860451
##########
src/java/org/apache/cassandra/schema/CompressionParams.java:
##########
@@ -223,6 +230,7 @@ private CompressionParams(ICompressor sstableCompressor,
int chunkLength, int ma
this.otherOptions = ImmutableMap.copyOf(otherOptions);
this.minCompressRatio = minCompressRatio;
this.maxCompressedLength = maxCompressedLength;
+ this.decoratedSstableCompressor = decorateCompressor(sstableCompressor,
otherOptions);
Review Comment:
do we actually need `decoratedSstableCompressor`? I propose to do something
like
this.sstableCompressor = maybeDecorateCompressor(sstableCompressor,
otherOptions);
Then sstableCompressor would be either decorated or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
