shyla226 commented on code in PR #4513:
URL: https://github.com/apache/cassandra/pull/4513#discussion_r2624985349


##########
src/java/org/apache/cassandra/io/compress/CompressedSequentialWriter.java:
##########
@@ -109,7 +109,7 @@ public CompressedSequentialWriter(File file,
                             
.bufferType(parameters.getSstableCompressor().preferredBufferType())
                             .finishOnClose(option.finishOnClose())
                             .build());
-        ICompressor compressor = parameters.getSstableCompressor();

Review Comment:
   Agree. Reasoning for doing it this way, `sstableCompressor` being final  it 
can be changed only in the `createCompressor` function. But if I change it 
there, `CompressionMetadata `also gets updated and stored. 
   Any thoughts how I could overcome this issue?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to