samueldlightfoot commented on code in PR #4178: URL: https://github.com/apache/cassandra/pull/4178#discussion_r2659652520
########## src/java/org/apache/cassandra/io/util/DirectThreadLocalReadAheadBuffer.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.io.util; + +import java.nio.ByteBuffer; + +import org.agrona.BitUtil; +import org.agrona.BufferUtil; +import org.apache.cassandra.io.sstable.CorruptSSTableException; + +public final class DirectThreadLocalReadAheadBuffer extends ThreadLocalReadAheadBuffer +{ + + private final int blockSize; + + private DirectThreadLocalReadAheadBuffer(ChannelProxy channel, int bufferSize, int blockSize) + { + super(channel, bufferSize, () -> BufferUtil.allocateDirectAligned(bufferSize, blockSize)); + this.blockSize = blockSize; + } + + @Override + protected void loadBlock(ByteBuffer blockBuffer, long blockPosition, int sizeToRead) + { + int alignedSizeToRead = BitUtil.align(sizeToRead, blockSize); Review Comment: The start position is aligned in org.apache.cassandra.io.util.ThreadLocalReadAheadBuffer#fill ` - Handled in ThreadLocalReadAheadBuffer.java:107-108 - blockPosition = blockNo * bufferSize - Since bufferSize is aligned to blockSize (line 51), the start position is block-aligned ` ########## src/java/org/apache/cassandra/io/util/DirectThreadLocalReadAheadBuffer.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.io.util; + +import java.nio.ByteBuffer; + +import org.agrona.BitUtil; +import org.agrona.BufferUtil; +import org.apache.cassandra.io.sstable.CorruptSSTableException; + +public final class DirectThreadLocalReadAheadBuffer extends ThreadLocalReadAheadBuffer +{ + + private final int blockSize; + + private DirectThreadLocalReadAheadBuffer(ChannelProxy channel, int bufferSize, int blockSize) + { + super(channel, bufferSize, () -> BufferUtil.allocateDirectAligned(bufferSize, blockSize)); + this.blockSize = blockSize; + } + + @Override + protected void loadBlock(ByteBuffer blockBuffer, long blockPosition, int sizeToRead) + { + int alignedSizeToRead = BitUtil.align(sizeToRead, blockSize); Review Comment: The start position is aligned in org.apache.cassandra.io.util.ThreadLocalReadAheadBuffer#fill ` - Handled in ThreadLocalReadAheadBuffer.java:107-108 - blockPosition = blockNo * bufferSize - Since bufferSize is aligned to blockSize (line 51), the start position is block-aligned ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
