samueldlightfoot commented on code in PR #4178:
URL: https://github.com/apache/cassandra/pull/4178#discussion_r2659692081
##########
src/java/org/apache/cassandra/io/util/FileHandle.java:
##########
@@ -62,17 +70,41 @@ public class FileHandle extends SharedCloseableImpl
*/
private final Optional<CompressionMetadata> compressionMetadata;
+ private final DiskAccessMode diskAccessMode;
+
+ // Properties to support unbuilding via toBuilder
+ private final ChunkCache chunkCache;
Review Comment:
I agree, however I'm not sure on a better alternative. Originally I had a
new dataFileFactory function variable on the SSTableReader that allowed to
modify the diskAccessMode, but it sprawled more than adding the unbuild support
as it needed all usaged to set the new prop.
Curious if you have any other thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
