dcapwell commented on code in PR #4556:
URL: https://github.com/apache/cassandra/pull/4556#discussion_r2683643993
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -583,6 +583,10 @@ public static class SSTableConfig
public volatile int tombstone_warn_threshold = 1000;
public volatile int tombstone_failure_threshold = 100000;
+ public volatile boolean write_thresholds_enabled = false;
+ public volatile DataStorageSpec.LongBytesBound write_size_warn_threshold =
null;
+ public volatile int write_tombstone_warn_threshold = 1000;
Review Comment:
use `-1` for disabled. The reason that
```
public volatile int tombstone_warn_threshold = 1000;
public volatile int tombstone_failure_threshold = 100000;
```
have values is that we retro fit those old behaviors *into* read_thresholds,
which fixed their behavior to work better. They are the only configs enabled
by default and have been enabled for years.
read thresholds has been around for awhile, so I might send a patch to
enable things by default, but that still won't change this patch as this patch
adds a *new* feature; so should be off by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
