dcapwell commented on code in PR #4556:
URL: https://github.com/apache/cassandra/pull/4556#discussion_r2683673850
##########
src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java:
##########
@@ -656,6 +657,10 @@ private ResultMessage executeWithoutCondition(QueryState
queryState, QueryOption
);
if (!mutations.isEmpty())
{
+ // Check write thresholds at coordinator level - similar to read
threshold checking
+ maybeWarnWriteSize(mutations, options);
+ maybeWarnWriteTombstones(mutations, options);
Review Comment:
why is this logic here rather than in the write coordination like read is?
Wasn't the assumption that we check replica state which wouldn't be possible
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
