maedhroz commented on code in PR #4353:
URL: https://github.com/apache/cassandra/pull/4353#discussion_r2684025603
##########
src/java/org/apache/cassandra/index/sai/StorageAttachedIndexGroup.java:
##########
@@ -173,6 +173,15 @@ public Index.Indexer indexerFor(Predicate<Index>
indexSelector,
return indexers.isEmpty() ? null : new Index.Indexer()
{
+ @Override
+ public void begin()
+ {
+ // TODO is this a good solution? I only need this because we
do not always
+ // indexed everything in insertRow and updateRow.
+ for (Index.Indexer indexer : indexers)
+ indexer.begin();
Review Comment:
SAI obviously doesn't index deletes, but what you're saying is that we need
to do the initialization even when the only operations on the Memtable are
deletes? Ideally, even if that's true, we'd also want to avoid the iterator
creation on delete when there are no Vector indexes, but I want to understand
the first thing better...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
