maedhroz commented on code in PR #4353:
URL: https://github.com/apache/cassandra/pull/4353#discussion_r2692532108
##########
src/java/org/apache/cassandra/index/sai/memory/MemtableIndexManager.java:
##########
@@ -92,6 +102,7 @@ public long update(DecoratedKey key, Row oldRow, Row newRow,
Memtable memtable)
return index(key, newRow, memtable);
}
+ // TODO when do we hit this case? It isn't covered by tests.
Review Comment:
Agreed an assertion is probably best. The only other thing I'd consider is
just calling `maybeInitializeMemtableIndex(Memtable memtable)` ->
`switchMemtable(Memtable next)` to follow the pattern of `renewMemtable()` and
`discardMemtable()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
