arvindKandpal-ksolves commented on PR #4412: URL: https://github.com/apache/cassandra/pull/4412#issuecomment-3743705988
Hi @dcapwell, thanks for the feedback. I have addressed the major points and verified them locally: Operator Logic: Updated isSatisfiedBy to use type.unwrap() for correct handling of reversed columns. Counters Bug: Fixed SimpleRestriction to skip sorting for Counter types (resolving the UnsupportedOperationException). Tests & License: Added the missing license header to BetweenInversionTest and updated SelectSingleColumnRelationTest to expect empty results for inverted bounds. Current Issue: I am facing some complex edge cases in `SelectMultiColumnRelationTest` regarding mixed-order clustering columns. The row counts are inconsistent with the new empty-result logic. Could you please review these? Also, any advice on how to handle those specific mixed-order multi-column tests would be really helpful. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
