dcapwell commented on code in PR #4412:
URL: https://github.com/apache/cassandra/pull/4412#discussion_r2709872504
##########
test/harry/main/org/apache/cassandra/harry/model/ASTSingleTableModel.java:
##########
@@ -1640,6 +1645,18 @@ private List<PrimaryKey> applyLimits(List<PrimaryKey>
primaryKeys, Optional<Valu
return primaryKeys;
}
+ private boolean shouldReverse(Select.OrderBy orderBy)
+ {
+ for (var block : orderBy.ordered)
+ {
+ Symbol col = (Symbol) block.expression; //TODO (coverage): do we
support anything other than symbol?
+ col = factory.clusteringColumns.get(col); // switch to table
symbol so we know if its reversed or not
Review Comment:
right now Order By uses `Symbol` but I think i made it more generic in case
we moved closer to how SQL works... but it should be a symbol 100% of the time
today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
