blambov commented on code in PR #4536:
URL: https://github.com/apache/cassandra/pull/4536#discussion_r2686088121
##########
src/java/org/apache/cassandra/io/sstable/metadata/MetadataCollector.java:
##########
@@ -245,10 +246,27 @@ public void update(LivenessInfo newInfo)
public void update(Cell<?> cell)
{
++currentPartitionCells;
- updateTimestamp(cell.timestamp());
- updateTTL(cell.ttl());
- updateLocalDeletionTime(cell.localDeletionTime());
- if (!cell.isLive(nowInSec))
+ long timestamp;
+ int ttl;
+ long localDeletionTime;
+ if (cell.getClass() == ArrayCell.class)
Review Comment:
Doesn't it make better sense to change the one in `serialize` to `instanceof
ArrayCell` (flush vs compaction) then?
Or you can leave as is, but please leave a comment to say why we chose the
specific type to check against.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
