netudima commented on code in PR #4536:
URL: https://github.com/apache/cassandra/pull/4536#discussion_r2686143173
##########
src/java/org/apache/cassandra/db/partitions/AbstractBTreePartition.java:
##########
@@ -171,6 +171,12 @@ public UnfilteredRowIterator unfilteredIterator()
return unfilteredIterator(ColumnFilter.selection(columns()),
Slices.ALL, false);
}
+ public UnfilteredRowIterator flushingIterator(TableMetadata tableMetadata)
+ {
+ return unfilteredIterator(ColumnFilter.all(columns()), Slices.ALL,
false);
Review Comment:
yes, it looks like I was too afraid to break some read flow logic here, but
logically the filtering should do nothing: columns() here is not from a
memtable level but these are columns are for this specific partition, so they
should be in sync with values.
I will update overriden
org.apache.cassandra.db.memtable.TrieMemtable.MemtablePartition#unfilteredIterator()
as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
