michaeljmarshall commented on code in PR #4353:
URL: https://github.com/apache/cassandra/pull/4353#discussion_r2696298443
##########
src/java/org/apache/cassandra/index/sai/StorageAttachedIndexGroup.java:
##########
@@ -173,6 +173,15 @@ public Index.Indexer indexerFor(Predicate<Index>
indexSelector,
return indexers.isEmpty() ? null : new Index.Indexer()
{
+ @Override
+ public void begin()
+ {
+ // TODO is this a good solution? I only need this because we
do not always
+ // indexed everything in insertRow and updateRow.
+ for (Index.Indexer indexer : indexers)
+ indexer.begin();
Review Comment:
I update the logic so we can use the `MemtableSwitchedNotification`
notification and eagerly create the index object when it is a vector column.
##########
src/java/org/apache/cassandra/index/sai/StorageAttachedIndexGroup.java:
##########
@@ -173,6 +173,15 @@ public Index.Indexer indexerFor(Predicate<Index>
indexSelector,
return indexers.isEmpty() ? null : new Index.Indexer()
{
+ @Override
+ public void begin()
+ {
+ // TODO is this a good solution? I only need this because we
do not always
+ // indexed everything in insertRow and updateRow.
+ for (Index.Indexer indexer : indexers)
+ indexer.begin();
Review Comment:
I updated the logic so we can use the `MemtableSwitchedNotification`
notification and eagerly create the index object when it is a vector column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
