netudima commented on code in PR #4551:
URL: https://github.com/apache/cassandra/pull/4551#discussion_r2704366911
##########
src/java/org/apache/cassandra/tools/nodetool/CompactionStats.java:
##########
@@ -56,7 +56,21 @@ public void execute(NodeProbe probe)
TableBuilder tableBuilder = new TableBuilder();
pendingTasksAndConcurrentCompactorsStats(probe, tableBuilder);
compactionsStats(probe, tableBuilder);
-
reportCompactionTable(probe.getCompactionManagerProxy().getCompactions(),
probe.getCompactionThroughputBytes(), humanReadable, vtableOutput, out,
tableBuilder);
+ Map<String, String> currentCompactionThroughputMetricsMap =
probe.getCurrentCompactionThroughputMiBPerSec();
+ String currentThroughput1MinStr =
currentCompactionThroughputMetricsMap.get("1minute");
Review Comment:
it was my suggestion in the ticket, to use the most recent speed value,
5/15m stats may warm up too long, so you may get less accurate values at the
beginning of compaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
