smiklosovic commented on code in PR #4551:
URL: https://github.com/apache/cassandra/pull/4551#discussion_r2704368165
##########
src/java/org/apache/cassandra/tools/nodetool/CompactionStats.java:
##########
@@ -118,10 +132,15 @@ private void compactionsStats(NodeProbe probe,
TableBuilder tableBuilder)
public static void reportCompactionTable(List<Map<String,String>>
compactions, long compactionThroughputInBytes, boolean humanReadable,
PrintStream out, TableBuilder table)
{
- reportCompactionTable(compactions, compactionThroughputInBytes,
humanReadable, false, out, table);
+ reportCompactionTable(compactions, compactionThroughputInBytes, null,
humanReadable, false, out, table);
}
public static void reportCompactionTable(List<Map<String,String>>
compactions, long compactionThroughputInBytes, boolean humanReadable, boolean
vtableOutput, PrintStream out, TableBuilder table)
+ {
+ reportCompactionTable(compactions, compactionThroughputInBytes, null,
humanReadable, vtableOutput, out, table);
+ }
+
+ public static void reportCompactionTable(List<Map<String,String>>
compactions, long compactionThroughputInBytes, Double
currentCompactionThroughputMiBPerSec, boolean humanReadable, boolean
vtableOutput, PrintStream out, TableBuilder table)
Review Comment:
would not it be nice if all number parameters are primitives for being
consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
