smiklosovic commented on code in PR #4596:
URL: https://github.com/apache/cassandra/pull/4596#discussion_r2749175244
##########
src/java/org/apache/cassandra/cql3/QueryProcessor.java:
##########
@@ -513,6 +522,62 @@ public static Prepared parseAndPrepare(String query,
ClientState clientState, bo
return res;
}
+ private static void checkMispreparedGuardrail(CQLStatement statement,
ClientState clientState)
+ {
+ if (clientState.isInternal)
Review Comment:
just move this to above if, this method will have easier job / will be more
focused, logic wise. I have not check the details yet but it is interesting to
see that if isInternal is false then clientState.internal can be still true.
Should not be these two just aligned so only one is necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
