smiklosovic commented on code in PR #4596:
URL: https://github.com/apache/cassandra/pull/4596#discussion_r2749201012
##########
conf/cassandra.yaml:
##########
@@ -2531,6 +2531,10 @@ drop_compact_storage_enabled: false
# This would also apply to system keyspaces.
# maximum_replication_factor_warn_threshold: -1
# maximum_replication_factor_fail_threshold: -1
+#
+# When true, allows the use of misprepared statements, only warns in the logs.
+# When false, misprepared statements will result in an error to the client.
Default is true.
+# use_misprepare_statements_enabled: false
Review Comment:
I think it would be better if the name of this was
"disallow_misprepared_statements: true". If you look into other guardrails, all
of them follow the logic that they are set to "true".
Then you will have way easier job later in the code as you can just do
Guardrails.disallowMispreparedStatements.ensureEnabled(state)
and be done with it, no enabled / ensureEnabled etc ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
