skoppu22 commented on code in PR #312:
URL: https://github.com/apache/cassandra-sidecar/pull/312#discussion_r2763382248
##########
server/src/main/java/org/apache/cassandra/sidecar/cluster/instance/InstanceMetadataImpl.java:
##########
@@ -237,6 +254,7 @@ public static class Builder implements
DataObjectBuilder<Builder, InstanceMetada
protected String host;
protected String ipAddress;
protected int port;
+ protected int storagePort = DEFAULT_STORAGE_PORT;
Review Comment:
I view the Sidecar as a service exposing data/config of Cassandra servers in
the cluster, so developers/users can work with Cassandra accordingly. Is it OK
to use Sidecar's local DEFAULT_STORAGE_PORT value here? Why don't we just give
whatever we got from the Cassandra server? If we get null/nothing from the
server, we can either set something like -1 or error message in the Sidecar's
response, somehow indicating to the caller that Sidecar unable to get this
value from the server? My perspective is, using Sidecar's own local values may
mislead developers/users while debugging an issue with Cassandra.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
