frankgh commented on code in PR #312:
URL: https://github.com/apache/cassandra-sidecar/pull/312#discussion_r2789721852
##########
server/src/main/java/org/apache/cassandra/sidecar/config/yaml/InstanceConfigurationImpl.java:
##########
@@ -33,9 +33,15 @@
*/
public class InstanceConfigurationImpl implements InstanceConfiguration
{
+ /**
+ * Default storage port for Cassandra inter-node communication.
+ */
+ public static final int DEFAULT_STORAGE_PORT = 7000;
+
protected final int id;
protected final String host;
protected final int port;
+ protected final Integer storagePort;
Review Comment:
should this be int now that it's always provided?
##########
server/src/main/java/org/apache/cassandra/sidecar/config/yaml/InstanceConfigurationImpl.java:
##########
@@ -119,6 +127,17 @@ public int port()
return port;
}
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ @JsonProperty("storage_port")
+ @Nullable
+ public Integer storagePort()
Review Comment:
can we make this int as well? And the interface should also be a primitive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
