arnav-chakraborty opened a new pull request, #4607:
URL: https://github.com/apache/cassandra/pull/4607
## PR Description:
Prevent TombstoneOverwhelmingException from being swallowed when tracking
warnings
In `ReadCommandVerbHandler.doVerb()`, when `trackWarnings=true`, all
`RejectException` subclasses are caught and swallowed — an empty success
response is sent with failure info in `MessageParams`. While the coordinator
eventually
recognizes the failure via the side-channel params,
`TombstoneOverwhelmingException` is a hard abort that should propagate as a
proper failure response, not masquerade as a success.
The fix adds `|| e instanceof TombstoneOverwhelmingException` to the catch
block so it is always re-thrown. Other `RejectException` subclasses
(`LocalReadSizeTooLargeException`, `QueryReferencingTooManyIndexesException`)
continue
using the `MessageParams` path since they're designed for `WarningContext`
aggregation.
patch by Arnav Chakraborty; for CASSANDRA-21072
Co-authored-by: Arnav Chakraborty <[email protected]>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
