Copilot commented on code in PR #4607:
URL: https://github.com/apache/cassandra/pull/4607#discussion_r2790358202
##########
src/java/org/apache/cassandra/db/ReadCommandVerbHandler.java:
##########
@@ -88,7 +89,7 @@ public void doVerb(Message<ReadCommand> message)
}
catch (RejectException e)
{
- if (!command.isTrackingWarnings())
+ if (!command.isTrackingWarnings() || e instanceof
TombstoneOverwhelmingException)
throw e;
Review Comment:
The new special-casing for TombstoneOverwhelmingException is covered by
tests, but there is still no unit test asserting the opposite branch: when
TRACK_WARNINGS is enabled and a *different* RejectException (e.g.,
LocalReadSizeTooLargeException / QueryReferencingTooManyIndexesException) is
thrown, doVerb should swallow it and send an empty success response with the
corresponding MessageParams populated. Adding a test for this would protect
against future regressions in the warning-tracking path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
