jyothsnakonisa commented on code in PR #316:
URL: https://github.com/apache/cassandra-sidecar/pull/316#discussion_r2794828237


##########
conf/sidecar.yaml:
##########
@@ -344,6 +339,13 @@ healthcheck:
   initial_delay: 0ms
   execute_interval: 30s
 
+# Cluster Topology Monitor settings
+# Monitors Cassandra cluster topology changes and publishes events when 
detected
+cluster_topology_monitor:
+  enabled: true
+  initial_delay: 0s
+  execute_interval: 1000ms  # Interval between topology refresh cycles

Review Comment:
   @jmckenzie-dev there was a default hardcoded value for the delay prior to 
this patch which was 1000ms. In this patch I am making the delay configurable 
and used the older value as default.
   
   I agree, will add more comments around the props and what could be a 
reasonable value for the props.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to