jyothsnakonisa commented on code in PR #316:
URL: https://github.com/apache/cassandra-sidecar/pull/316#discussion_r2794874645
##########
server/src/main/java/org/apache/cassandra/sidecar/config/yaml/SidecarConfigurationImpl.java:
##########
@@ -415,6 +429,10 @@ public static class Builder implements
DataObjectBuilder<Builder, SidecarConfigu
= new PeriodicTaskConfigurationImpl(true,
MillisecondBoundConfiguration.ZERO,
MillisecondBoundConfiguration.parse("30s"));
+ private PeriodicTaskConfiguration clusterTopologyMonitorConfiguration
+ = new PeriodicTaskConfigurationImpl(true,
+ MillisecondBoundConfiguration.ZERO,
+
MillisecondBoundConfiguration.parse("1000ms"));
Review Comment:
You are right, I followed same convention
`clusterTopologyMonitorConfiguration` considering other methods in
`SidecarConfigurationImpl`. However these defaults will get replaced by the
values in config file here
https://github.com/apache/cassandra-sidecar/blob/bab2da8431296a3fe147397683b071d0dd7eafa0/server/src/main/java/org/apache/cassandra/sidecar/CassandraSidecarDaemon.java#L47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
