samueldlightfoot commented on code in PR #4606:
URL: https://github.com/apache/cassandra/pull/4606#discussion_r2817875926
##########
src/java/org/apache/cassandra/io/sstable/format/SSTableReader.java:
##########
@@ -1417,44 +1419,60 @@ public StatsMetadata getSSTableMetadata()
return sstableMetadata;
}
+ public RandomAccessReader openDataReader()
Review Comment:
This one may not be worth it. We'd have to make sure the original dFile is
available to callers so they can pass dFile.diskAccessMode() in (i.e. the
default).
There are currently >10 usages of openDataReader/openDataReaderForScan that
we'd have to pass it through for, and I can see a couple at a glance that do
not have access to the FileHandle for the data file (dFile).
We could improve the docs to indicate the files default disk access mode
will be used for these overloads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
