samueldlightfoot commented on code in PR #4606:
URL: https://github.com/apache/cassandra/pull/4606#discussion_r2818156501
##########
src/java/org/apache/cassandra/io/util/DirectThreadLocalReadAheadBuffer.java:
##########
@@ -46,4 +49,14 @@ protected void loadBlock(ByteBuffer blockBuffer, long
blockPosition, int sizeToR
if (channel.read(blockBuffer, blockPosition) < sizeToRead)
throw new CorruptSSTableException(null, channel.filePath());
}
+
+ @Override
+ protected void cleanBuffer(ByteBuffer buffer)
Review Comment:
Strongly agree it should throw - it would have detected the potential leak.
I have pushed changes around attachment handling, which also as a byproduct fix
Mmaped ByteBuffer cleaning which have the cleaner as their attachment - they
were silently no-op-ing prior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
