Mmuzaf commented on code in PR #4617:
URL: https://github.com/apache/cassandra/pull/4617#discussion_r2867814447
##########
src/java/org/apache/cassandra/tools/nodetool/DescribeCluster.java:
##########
@@ -31,14 +31,18 @@
import org.apache.cassandra.tools.NodeProbe;
import picocli.CommandLine.Command;
+import picocli.CommandLine.Mixin;
@Command(name = "describecluster", description = "Print the name, snitch,
partitioner and schema version of a cluster")
-public class DescribeCluster extends WithPortDisplayAbstractCommand
+public class DescribeCluster extends AbstractCommand
{
private boolean resolveIp = false;
private String keyspace = null;
private Collection<String> joiningNodes, leavingNodes, movingNodes,
liveNodes, unreachableNodes;
+ @Mixin
+ private PrintPortMixin printPortMixin = new PrintPortMixin();
Review Comment:
Correct. On the other hand, we have a pattern where all the command
parameters are explicitly initialized with their default values, so this is
just for the same of consistency accross all other usages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
