Mmuzaf commented on code in PR #4617:
URL: https://github.com/apache/cassandra/pull/4617#discussion_r2867814767
##########
src/java/org/apache/cassandra/tools/NodeTool.java:
##########
@@ -57,6 +59,19 @@ public class NodeTool
private static final String HISTORYFILE = "nodetool.history";
+ /**
+ * Set of subcommand names that accept the {@code -pp/--print-port}
options.
+ * These are the commands that declare the option via @Mixin and thus
require
+ * relocating the option for backward compatibility in order to be
recognized
+ * by picocli when specified before the subcommand name.
+ * <p>
+ * Both calls such as {@code ./nodetool --print-port status}, and
+ * {@code ./nodetool status --print-port} should work as expected.
+ */
+ private static final Set<String> PRINT_PORT_COMMANDS = Set.of("status",
"ring", "netstats", "gossipinfo",
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
