belliottsmith commented on PR #4746: URL: https://github.com/apache/cassandra/pull/4746#issuecomment-4386456258
Looks good, and great catch. Why don't we move the AbstractUpdater.reset() method up to `AbstractFastBuilder` though? I don't think there's a reason not to share it, and we only need to get the logic right once. It looks like we also are not clearing `hasRightChild` in the FastBuilder version, for instance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
