netudima commented on code in PR #4841:
URL: https://github.com/apache/cassandra/pull/4841#discussion_r3323687600
##########
src/java/org/apache/cassandra/metrics/TableMetrics.java:
##########
@@ -166,6 +166,10 @@ public class TableMetrics
public final TableHistogram purgeableTombstoneScannedHistogram;
/** Live rows scanned in queries on this CF */
public final TableHistogram liveScannedHistogram;
+ /** Total number of live rows read from this CF (cumulative counter,
suitable for rate/windowed calculations) */
+ public final Counter rowsRead;
Review Comment:
probably it is better to name it as totalRowsRead (or rowsReadTotal) and
similar for mutated to make it more clear that it is a total (comulative) number
We have already similar naming for totalLatency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
