netudima commented on code in PR #4841:
URL: https://github.com/apache/cassandra/pull/4841#discussion_r3323750796
##########
src/java/org/apache/cassandra/metrics/TableMetrics.java:
##########
@@ -166,6 +166,10 @@ public class TableMetrics
public final TableHistogram purgeableTombstoneScannedHistogram;
/** Live rows scanned in queries on this CF */
public final TableHistogram liveScannedHistogram;
+ /** Total number of live rows read from this CF (cumulative counter,
suitable for rate/windowed calculations) */
+ public final Counter rowsRead;
+ /** Total number of rows mutated in writes to this CF (cumulative counter,
suitable for rate/windowed calculations) */
+ public final Counter rowsMutated;
Review Comment:
probably it also to use Written term here to be aligned in naming with
latency metrics for writes
##########
src/java/org/apache/cassandra/metrics/TableMetrics.java:
##########
@@ -166,6 +166,10 @@ public class TableMetrics
public final TableHistogram purgeableTombstoneScannedHistogram;
/** Live rows scanned in queries on this CF */
public final TableHistogram liveScannedHistogram;
+ /** Total number of live rows read from this CF (cumulative counter,
suitable for rate/windowed calculations) */
+ public final Counter rowsRead;
+ /** Total number of rows mutated in writes to this CF (cumulative counter,
suitable for rate/windowed calculations) */
+ public final Counter rowsMutated;
Review Comment:
probably it also to use Written term here instead of Mutated to be aligned
in naming with latency metrics for writes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
