toptobes commented on code in PR #582: URL: https://github.com/apache/cassandra-cpp-driver/pull/582#discussion_r3393125948
########## CMakeLists.txt: ########## @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.10) +cmake_minimum_required(VERSION 3.5) Review Comment: Looking at the git logs, I'm fairly certain what happened is that they were originally basing this off the version of the c++ driver 2 weeks before this PR was created, when it was still using cmake version `2.8.12` (so this was intended as an upgrade, not a downgrade) See: ```rb ❯ git lg * a22a11a3 golddevelopment - (HEAD -> gold-development/trunk) add support for appleclang and update cmake (5 months ago) * e5a486ac Sigmanificient - Bump minimum required version for cmake4 compatibility (5 months ago) ``` ```rb ❯ git lg -L 1,1:CMakeLists.txt * a22a11a3 golddevelopment - (HEAD -> gold-development/trunk) add support for appleclang and update cmake (5 months ago)| | diff --git a/CMakeLists.txt b/CMakeLists.txt | --- a/CMakeLists.txt | +++ b/CMakeLists.txt | @@ -1,1 +1,1 @@ | -cmake_minimum_required(VERSION 3.10) | +cmake_minimum_required(VERSION 3.5) * e5a486ac Sigmanificient - Bump minimum required version for cmake4 compatibility (5 months ago)| | diff --git a/CMakeLists.txt b/CMakeLists.txt | --- a/CMakeLists.txt | +++ b/CMakeLists.txt | @@ -1,1 +1,1 @@ | -cmake_minimum_required(VERSION 2.8.12) | +cmake_minimum_required(VERSION 3.10) ``` [P.S. `AppleClang` only got differentiated from `Clang` in `3.0` which is why this wasn't an issue previously](https://cmake.org/cmake/help/latest/policy/CMP0025.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
