absurdfarce commented on code in PR #582: URL: https://github.com/apache/cassandra-cpp-driver/pull/582#discussion_r3393306062
########## CMakeLists.txt: ########## @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.10) +cmake_minimum_required(VERSION 3.5) Review Comment: This seems reasonable @toptobes but even if it is the case I'd still argue for a uniform cmake requirement throughout the project. Note [the commit](https://github.com/apache/cassandra-cpp-driver/commit/e5a486ac52b99ae74d40e285b4438252fcf3b07a) referenced above; in that case we updated cmake_minimum_required() throughout the project. If we're going to change the cmake requirement _at all_ here it seems like we should do the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
