pauloricardomg commented on code in PR #360:
URL: https://github.com/apache/cassandra-sidecar/pull/360#discussion_r3406169010
##########
server/src/main/java/org/apache/cassandra/sidecar/job/OperationalJobManager.java:
##########
@@ -101,10 +118,12 @@ public void trySubmitJob(OperationalJob job,
checkConflict(job);
// New job is submitted for all cases when we do not have a
corresponding downstream job
- jobTracker.computeIfAbsent(job.jobId(), jobId -> {
+ OperationalJob tracked = jobTracker.computeIfAbsent(job.jobId(),
jobId -> job);
Review Comment:
do we need to remove from jobTracker if there's a coordination conflict ? Or
perhaps should we just add to jobTracker in case the tryCoordination was
successful, so tryCoordination should come before jobtracker.computeIfAbsent ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
