isaacreath commented on code in PR #360:
URL: https://github.com/apache/cassandra-sidecar/pull/360#discussion_r3437163382


##########
server/src/main/java/org/apache/cassandra/sidecar/job/OperationalJobManager.java:
##########
@@ -101,10 +118,12 @@ public void trySubmitJob(OperationalJob job,
             checkConflict(job);
 
             // New job is submitted for all cases when we do not have a 
corresponding downstream job
-            jobTracker.computeIfAbsent(job.jobId(), jobId -> {
+            OperationalJob tracked = jobTracker.computeIfAbsent(job.jobId(), 
jobId -> job);

Review Comment:
   Would it make sense to mark the job as `FAILED` if coordination fails? And 
set the `failureReason` to indicate that the job was not able to start due to 
coordination failure?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to