bdeggleston commented on code in PR #4708:
URL: https://github.com/apache/cassandra/pull/4708#discussion_r3444311706
##########
src/java/org/apache/cassandra/service/AbstractWriteResponseHandler.java:
##########
@@ -287,9 +296,12 @@ protected final void logFailureOrTimeoutToIdealCLDelegate()
}
}
- public final void expired()
+ public final void expired(InetAddressAndPort from)
{
+ plan.responses().onFailure(from, RequestFailureReason.NODE_DOWN);
Review Comment:
removed RequestFailureReason from ResponseTracker, it was never used. Yeah
it's been a while since I wrote this, but IIRC the lack of signaling was
causing some of my tests to fail because they were just relying on the timeout.
I can't think of a reason we wouldn't want to signal here though. It's
basically a non-messaging failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
