bdeggleston commented on code in PR #4708:
URL: https://github.com/apache/cassandra/pull/4708#discussion_r3444558581
##########
src/java/org/apache/cassandra/service/reads/ReadCallback.java:
##########
@@ -231,14 +227,15 @@ public void onResponse(Message<ReadResponse> message)
}
resolver.preprocess(message);
replicaPlan().collectSuccess(message.from());
+ plan.responses().onResponse(from);
Review Comment:
yeah I agree, I'll make a jira to clean that up a bit more. I think there's
also some additional cleanup/refactoring that can be done between replica plans
and response trackers, but I just haven't had the time to do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
