maedhroz commented on code in PR #4902:
URL: https://github.com/apache/cassandra/pull/4902#discussion_r3482902069
##########
test/distributed/org/apache/cassandra/distributed/test/QueriesTableTest.java:
##########
@@ -121,13 +121,13 @@ private static void assertReadsAndWritesVisible()
String task = row.get("task").toString();
boolean localReaderThread = threadId.contains("Read") ||
threadId.contains("SharedPool-Worker");
- readVisible |= localReaderThread && task.contains("SELECT");
+ readVisible |= localReaderThread && task.contains("SELECT") &&
!task.contains("QUERY");
Review Comment:
From CC shallow review:
> The tests disambiguate the new immediate-row from the enclosing-QUERY-row
by String.contains("QUERY") on the free-form task description, not by the
structural marker the patch actually introduces (the (immediate) suffix on
thread_id). If the local-read description ever
changes to mention "QUERY", or a user creates a keyspace/table literally
named QUERY, or someone re-uses the same test against a query reading from
system_views.queries, the assertion silently flips. The unambiguous signal is
thread_id ending with (immediate).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
